Open
Conversation
Fixed critical property name mismatches and inconsistencies in mjson files: data/model root level fixes: - digital-asset.mjson: Fixed secureLocation property name (was signedLocation) - physical-dimension.mjson: Fixed name property (was value) - identity.mjson: Fixed provider property name (was scope) and standardized prototype paths - unit.mjson: Fixed name property (was value) - ordering-rule.mjson: Fixed propertyvalidationRules typo (now validationRules) - variable.mjson: Fixed description typo (secialized → serialized) data/model/geo fixes: - Standardized all geo files to use "values" instead of "properties" - Affected files: line-string, multi-line-string, multi-point, polygon, point, circle, geometry, multi-polygon, projection, position These fixes ensure property descriptors match their references and maintain consistency across the codebase.
There was a problem hiding this comment.
Pull request overview
This PR fixes critical property name mismatches, typos, and inconsistencies in MJSON metadata files. The changes ensure property descriptors correctly match their actual property names and standardize the structure across geo-related files.
Key changes:
- Fixed property name mismatches where descriptor keys didn't align with their "name" values (e.g., secureLocation/signedLocation, provider/scope, name/value)
- Standardized all geo files to use "values" instead of "properties" for property descriptors
- Corrected spelling typo in variable.mjson description (secialized → serialized)
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| data/model/variable.mjson | Fixed spelling typo in description (secialized → serialized) |
| data/model/unit.mjson | Fixed property name from "value" to "name" to match actual property |
| data/model/physical-dimension.mjson | Fixed property name from "value" to "name" to match actual property |
| data/model/ordering-rule.mjson | Fixed typo: propertyvalidationRules → validationRules |
| data/model/identity.mjson | Fixed provider property name (was scope) and standardized prototype path |
| data/model/digital-asset.mjson | Fixed secureLocation property name (was signedLocation) |
| data/model/geo/projection.mjson | Standardized to use "values" instead of "properties" |
| data/model/geo/position.mjson | Standardized to use "values" instead of "properties" |
| data/model/geo/polygon.mjson | Standardized to use "values" instead of "properties" |
| data/model/geo/point.mjson | Standardized to use "values" instead of "properties" |
| data/model/geo/multi-polygon.mjson | Standardized to use "values" instead of "properties" |
| data/model/geo/multi-point.mjson | Standardized to use "values" instead of "properties" |
| data/model/geo/multi-line-string.mjson | Standardized to use "values" instead of "properties" |
| data/model/geo/line-string.mjson | Standardized to use "values" instead of "properties" |
| data/model/geo/geometry.mjson | Standardized to use "values" instead of "properties" |
| data/model/geo/circle.mjson | Standardized to use "values" instead of "properties" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed critical property name mismatches and inconsistencies in mjson files:
data/model root level fixes:
data/model/geo fixes:
These fixes ensure property descriptors match their references and maintain consistency across the codebase.